| Anonymous | Login | Signup for a new account | 2010-07-29 13:10 CDT |
| My View | View Issues | My Account |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
| 0003548 | [MindTouch] UI | major | @0@ | 2008-03-10 03:38 | 2008-04-08 18:36 | ||||
| Reporter | maffooclock | View Status | public | ||||||
| Assigned To | Guerric | ||||||||
| Priority | normal | Resolution | no change required | ||||||
| Status | closed | ||||||||
| Summary | 0003548: Dialog for 'Move page' and 'Insert image' functions do not work | ||||||||
| Description | When I try to move a page, the dialog that appears doesn't look right. None of the buttons work, including the 'Close' button. I can move the dialog around, but nothing else. Same goes for the 'Insert image' dialog. | ||||||||
| Additional Information |
I am using the Deki Hayes VM, which has been upgraded to Itasca using `updateWiki.sh` From the About page: You are using MindTouch Deki Wiki 1.9.0a (rev. 8690) running on: Linux 2.6.18-5-686, PHP 5.2.0-8+etch9, mySQL 14.12 distribution 5.0.32, and Mono 1.2.2.1. Also, I am using Firefox v2.0.0.12. I have cleared my cache and retried. I have also tried Internet Explorer 7, which yields the same behavior. The Error Console in Firefox does not list any JavaScript errors when attempting to use the 'Move page' feature. I have tried restarting dekihost, also, with no luck. I didn't have this problem before when using Hayes (I think). This issue is 100% reproducible, and any efforts to resolve myself this have been in vain. |
||||||||
| Tags | No tags attached. | ||||||||
| From Customer | No | ||||||||
| Likelihood | Affects average number of users | ||||||||
| Platform | All | ||||||||
| Regression | No | ||||||||
| Skin | All | ||||||||
| Version | trunk | ||||||||
| Target Release | 1.9.0 (Itasca) | ||||||||
| Browser | , All, | ||||||||
| Days Left | 0.5 | ||||||||
| Attached Files |
 screenshot.jpg [^] (135,383 bytes) 2008-03-10 03:38 screenshot2.jpg [^] (136,597 bytes) 2008-03-10 03:40 apache [^] (1,315 bytes) 2008-03-10 04:37 screenshot3.jpg [^] (131,650 bytes) 2008-03-10 04:38 screenshot4.jpg [^] (80,627 bytes) 2008-03-10 22:04 |
||||||||
|
|
|||||||||
 Relationships |
|
|
Notes |
|
|
(0006694) RoyK (administrator) 2008-03-10 04:30 |
But the link dialog works? |
|
(0006695) maffooclock (reporter) 2008-03-10 04:37 edited on: 2008-03-10 04:39 |
Well, now that you ask, that doesn't work either. Just to be clear, the following items do not work: Move page Insert image Update Link By the way, I have searched through your forums and documentation, and it seems the main problem people have is that @gui is not in the apache configuration. Well, I have checked, and I see that in my apache configuration. I have attached the /etc/apache2/sites-enabled/001-dekiwiki file. |
|
(0006700) RoyK (administrator) 2008-03-10 16:58 |
That's what I was going to ask :) Can you verify that when you hit http://wiki.opengarden.org/@gui/linknavigate/ [^] that you get an applicaton/json document returned and *not* the wiki's UI? |
|
(0006702) maffooclock (reporter) 2008-03-10 22:04 edited on: 2008-03-10 22:07 |
I did receive an application/json document (screenshot4 attached). By the way, you (or anyone else involved in helping with this) can test this first hand at http://wiki.uberclark.us/ [^] |
|
(0006704) merktnichts (reporter) 2008-03-10 22:21 |
Your line in the apache config file reads: RewriteCond %{REQUEST_URI} !/(@api|editor|skins|config|@gui)/ But it has to be: RewriteCond %{REQUEST_URI} !^/(@api|editor|skins|config|@gui)/ Please compare your apache file to the one in svn to be sure there's not more. I only checked that single line for you. |
|
(0006705) maffooclock (reporter) 2008-03-10 22:54 edited on: 2008-03-11 01:12 |
For the record: the only changes I have performed within the VM is `updateWiki.sh`, and nothing else. What I am getting at is that if I was to add the carat (or make any other changes to apache), I was not informed. If it's documented, then it isn't easy to find. But I did make the change you noted. I restarted apache, cleared my cache, and tried again -- no dice. |
|
(0006706) maffooclock (reporter) 2008-03-11 01:24 edited on: 2008-03-11 01:25 |
I figured it out! The 'Set site name' option in the 'Site settings' page contains a single quote: "Matt's Wiki" When I remove the single quote, everything works fine. The issue is in the function dialogInit(), which does not escape single quotes [for the siteName field]. |
|
(0006707) maffooclock (reporter) 2008-03-11 01:32 |
An addslashes() function is needed in the following locations: Line 85 of /var/www/deki-hayes/skins/common/popups/move_page_dialog.php Line 91 of /var/www/deki-hayes/skins/common/popups/link_dialog.php Line 91 of /var/www/deki-hayes/skins/common/popups/move_file_dialog.php Line 92 of /var/www/deki-hayes/skins/common/popups/image_dialog.php siteName: '<?php echo addslashes($wgSitename); ?>', |
|
(0006715) RoyK (administrator) 2008-03-11 19:53 |
Need encoding around anything generated into JS. |
|
(0006719) bobdvb (reporter) 2008-03-11 22:51 |
Also does not work for me (tested in https only environment). Updating redirects in apache conf files did not help. Site name had brackets in, removed with no difference to problem. Will try suggested addslashes additions. |
|
(0006720) bobdvb (reporter) 2008-03-11 22:56 |
Add slashes ineffective in this case. Please advise as to how to trace the fault as I am unable to move content or insert images from local storage. |
|
(0006732) Guerric (developer) 2008-03-12 20:21 |
Completed: At revision: 7661 |
|
(0007028) maffooclock (reporter) 2008-04-08 17:59 |
I hope I am not missing something, but today I ran `updateWiki.sh` and the problem has returned. I find it hard to believe this bug would be closed and marked 'Resolved' without the issue being really resolved. So, I assume I am an idiot, somehow... |
|
(0007029) maffooclock (reporter) 2008-04-08 18:06 edited on: 2008-04-08 18:09 |
Nevermind... CVS mangled my changes with yours: 83 <<<<<<< .mine 84 siteName: '<?php echo addslashes($wgSitename); ?>', 85 ======= 86 siteName: '<?php echo wfEncodeJSString($wgSitename); ?>', 87 >>>>>>> .r8921 I'll remove my changes and perform another update. SOrry for the noise, Please close. |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2008-03-10 03:38 | maffooclock | New Issue | |
| 2008-03-10 03:38 | maffooclock | File Added: screenshot.jpg | |
| 2008-03-10 03:38 | maffooclock | Branch | => trunk |
| 2008-03-10 03:38 | maffooclock | Target release | => 1.9.1 |
| 2008-03-10 03:38 | maffooclock | Browser | => All |
| 2008-03-10 03:42 | maffooclock | File Added: screenshot2.jpg | |
| 2008-03-10 03:44 | maffooclock | Issue Monitored: maffooclock | |
| 2008-03-10 04:30 | RoyK | Note Added: 0006694 | |
| 2008-03-10 04:37 | maffooclock | Note Added: 0006695 | |
| 2008-03-10 04:37 | maffooclock | File Added: apache | |
| 2008-03-10 04:38 | maffooclock | File Added: screenshot3.jpg | |
| 2008-03-10 04:39 | maffooclock | Note Edited: 0006695 | |
| 2008-03-10 16:58 | RoyK | Note Added: 0006700 | |
| 2008-03-10 22:04 | maffooclock | File Added: screenshot4.jpg | |
| 2008-03-10 22:04 | maffooclock | Note Added: 0006702 | |
| 2008-03-10 22:07 | maffooclock | Note Edited: 0006702 | |
| 2008-03-10 22:21 | merktnichts | Note Added: 0006704 | |
| 2008-03-10 22:54 | maffooclock | Note Added: 0006705 | |
| 2008-03-11 01:12 | maffooclock | Note Edited: 0006705 | |
| 2008-03-11 01:24 | maffooclock | Note Added: 0006706 | |
| 2008-03-11 01:25 | maffooclock | Note Edited: 0006706 | |
| 2008-03-11 01:32 | maffooclock | Note Added: 0006707 | |
| 2008-03-11 04:43 | RoyK | Assigned To | => RoyK |
| 2008-03-11 04:43 | RoyK | Status | new => assigned |
| 2008-03-11 19:53 | RoyK | Note Added: 0006715 | |
| 2008-03-11 22:51 | bobdvb | Note Added: 0006719 | |
| 2008-03-11 22:56 | bobdvb | Note Added: 0006720 | |
| 2008-03-12 19:26 | Guerric | Assigned To | RoyK => Guerric |
| 2008-03-12 20:21 | Guerric | Status | assigned => resolved |
| 2008-03-12 20:21 | Guerric | Resolution | open => fixed |
| 2008-03-12 20:21 | Guerric | Note Added: 0006732 | |
| 2008-03-14 16:22 | RoyK | Target release | 1.9.1 => 1.9.0 (Itasca) |
| 2008-04-08 09:33 | DmitryA | Status | resolved => closed |
| 2008-04-08 17:59 | maffooclock | Note Added: 0007028 | |
| 2008-04-08 17:59 | maffooclock | Status | closed => assigned |
| 2008-04-08 17:59 | maffooclock | Resolution | fixed => reopened |
| 2008-04-08 18:06 | maffooclock | Note Added: 0007029 | |
| 2008-04-08 18:09 | maffooclock | Note Edited: 0007029 | |
| 2008-04-08 18:36 | Guerric | Status | assigned => closed |
| 2008-04-08 18:36 | Guerric | Resolution | reopened => no change required |
| Mantis 1.1.1[^] Copyright © 2000 - 2008 Mantis Group |  |